search

monome / we

norns/dust: collected and collaborative projects
GNU General Public License v3.0
20 stars 12 forks source link

Not all scripts in this repo are self-contained #21

Open simonvanderveldt opened 5 years ago

simonvanderveldt commented 5 years ago

I noticed some scripts in this repo have external dependencies. For example the scales demo as well as several of the studies have a dependency on Polyperc, see https://github.com/monome/we/blob/master/demos/scales.lua#L39

I was wondering how we want to handle this? IMHO it would be better if the examples in this repo have no external dependencies.

okyeron commented 5 years ago

Troubleshooting a norns user on lines today and came up with this problem. demos/scales.lua needs Polyperc and this user did not have awake installed for some reason.

Update the example to use PolySub instead?

tehn commented 5 years ago

polysub is going to eventually also moved out of we

better fix is to just note the requirement in the comment text for now. we need to have more robust error messages for missing engines.

as a general note: not all scripts/repos are going to be self-contained, and will very commonly require engines from another repo.