search

mononoken / fae-scribe

0 stars 0 forks source link

Change CollectionInvitations to just Invitations #35

Closed mononoken closed 11 months ago

mononoken commented 12 months ago

I created CollectionInvitations thinking that there may be other types of invitations in the future such as friendship "invitations". However, in this case, I think we should just have Invitations and polymorphic relationships of "inviteable" things and/or "attendable" things.

mononoken commented 11 months ago

Since we are going with memberships and invitations as separate entities, this has exposed a problem with invitations as they currently exist.

Currently, invitations invite Journals. This infers that Journals are inviteable, but it is the user that should be inviteable. Users should personally choose which of their journals join a collection, not the person that is inviting the user.

Invitations should invite users. Memberships should track which journals are in the collection.

mononoken commented 11 months ago

2e29f34686f6215f2dc1cd40220420411a6ee8f6 fixes this issue.

Fixing the columns invitations will be moved to #36