Invitation#accept currently sets Membership role as member as a default. This feels a little off to me, like this responsibility should not lie here.
I have considered also that perhaps the Invitation should also have a role. That way, a user inviting another user can set a role for the person if they choose to accept. In that case, the role should be set equal to whatever the Invitation role is.
app/models/invitation.rbInvitation#accept currently sets Membership role as
memberas a default. This feels a little off to me, like this responsibility should not lie here.I have considered also that perhaps the Invitation should also have a role. That way, a user inviting another user can set a role for the person if they choose to accept. In that case, the role should be set equal to whatever the Invitation role is.