monospice / laravel-redis-sentinel-drivers

Redis Sentinel integration for Laravel and Lumen.
MIT License
101 stars 48 forks source link

Fix for Redis manager in Laravel 5.7 #19

Closed yupmin closed 5 years ago

yupmin commented 5 years ago
yupmin commented 5 years ago

Too few arguments to function Illuminate\Redis\RedisManager::__construct(), 2 passed in /Users/yupmin/PhpstormProjects/xxxxxxxx/vendor/monospice/laravel-redis-sentinel-drivers/src/Manager/VersionedManagerFactory.php on line 65 and exactly 3 expected

https://github.com/illuminate/redis/blob/v5.7.4/RedisManager.php

    /**
     * Create a new Redis manager instance.
     *
     * @param  \Illuminate\Foundation\Application  $app
     * @param  string  $driver
     * @param  array  $config
     * @return void
     */
    public function __construct($app, $driver, array $config)
    {
        $this->app = $app;
        $this->driver = $driver;
        $this->config = $config;
    }

https://github.com/illuminate/redis/blob/v5.6.38/RedisManager.php

    /**
     * Create a new Redis manager instance.
     *
     * @param  string  $driver
     * @param  array  $config
     * @return void
     */
    public function __construct($driver, array $config)
    {
        $this->driver = $driver;
        $this->config = $config;
    }
cyrossignol commented 5 years ago

Hi @yupmin, many thanks for finding and reporting this issue! This needs a bit more work to get the tests to pass and we need to configure Travis for 5.7. I'll finish this up and get a release out as soon as possible.

yupmin-ct commented 5 years ago

👍