Added autoboot configuration option and supporting implementation

monospice / laravel-redis-sentinel-drivers

Redis Sentinel integration for Laravel and Lumen.

MIT License

101 stars 48 forks source link

Added autoboot configuration option and supporting implementation #20

Closed dave-lang closed 5 years ago

dave-lang commented 5 years ago

This is to address the issue in https://github.com/monospice/laravel-redis-sentinel-drivers/issues/17

UPDATE: Added ENV & config vars 'REDIS_SENTINEL_AUTO_BOOT' & 'auto_boot' UPDATE: Configuration loader checks autoboot setting, provider will autoboot if this is set

dave-lang commented 5 years ago

Looks like we never got around to closing this off, the root issue was address in lumen-framework but it would be nice to get this cleaned up as well.

cyrossignol commented 5 years ago

Thanks for following up, Dave. I'm glad you found a solution in Lumen. With regard to my last message: in my haste, it looks like I accidentally pushed the fix for the tests to my backup repo instead of to Github, and then a bunch of year-end stuff came up at work so I failed to notice. Sorry to keep you waiting!

I'll merge this in and finish up the change over the next few days so you don't need to devote any more time to it. Thanks again for implementing this feature!

cyrossignol commented 5 years ago

@davoaust Thanks again for your time on this one. Sorry it took me so long to circle back!