search

monospice / laravel-redis-sentinel-drivers

Redis Sentinel integration for Laravel and Lumen.
MIT License
101 stars 48 forks source link

Version bump for L8 #33

Open skipworkgh opened 3 years ago

skipworkgh commented 3 years ago

Can we please get a new version bump, so that L8 is supported? Thanks!

chrispage1 commented 3 years ago

@skipworkgh looks like it's compatible with 8 :)

skipworkgh commented 3 years ago

The current released version does not suppert L8 just yet. Hence my question for a new version.

chrispage1 commented 3 years ago

Ah apologies - I was looking at the 2.x branch which does have the version bumps. I'd imagine that is all that's needed, maybe worth forking and testing it out?

skipworkgh commented 3 years ago

It is working as far as I've tested it. Without a version bump of this package however, it's impossible to include the L8 changes using composer.

cyrossignol commented 3 years ago

Sorry for the delay. My GitHub email notifications were not arriving. I thought that we finalized Laravel 8 support on the 2.x branch, but it looks like it was never tagged. I will push a release today.

Side note: for those who want to test development branches, we can set 2.x-dev as the version constraint for this package.

skipworkgh commented 3 years ago

@cyrossignol is there any particular reason why the new release isnt pushed yet?

GytisT commented 3 years ago

@cyrossignol @skipworkgh really looking forward to this to be able to upgrade to Laravel 8.0 in a straight forward way.

mbalandis commented 3 years ago

Still waiting :)

krzysztof-wojcik-ig commented 3 years ago

Hi @cyrossignol Could you please release that version? ;)

kristopher1 commented 3 years ago

Hi, @jacovdbergh @pdbreen @yupmin-ct Could you please release L8 version? ;)

ikari7789 commented 2 years ago

Hi @cyrossignol,

I understand that we all become quite busy, but it's been over a year since you mentioned "pushing a release today."

Has there been any progress on this? I'd like to be able to not have to refer to the "-dev" branch in my projects.

mbalandis commented 2 years ago

@ikari7789 If you want feel free to use this: https://github.com/sharpstream/laravel-redis-sentinel-drivers or fork youself. This dev ain't releasing it and I was fed up waiting. I tried it works fine in production on the latest code. Nothing has been altered.

DreadfulCode commented 2 years ago

It's now August of 2022, still no working sentinel configuration for Laravel v8, does not work with PHPredis driver. Is this package deprecated?

krzysztof-wojcik-ig commented 1 year ago

Hi @DreadfulCode it is possible to configure Redis sentinel in Laravel v8 without that library.

ikari7789 commented 1 year ago

Hi @krzysztof-wojcik-ig could you be so kind as to provide an example of how to configure it? I haven't seen any mention of it in the official Laravel docs.

krzysztof-wojcik-ig commented 1 year ago

Here you can find example config for it: https://maxinterview.com/code/laravel-redis-sentinel-30DB90D4DAFEC86/