Update RedisSentinelManager::Resolve() signature to match Laravel 5.4 update on 17 April

monospice / laravel-redis-sentinel-drivers

Redis Sentinel integration for Laravel and Lumen.

MIT License

101 stars 48 forks source link

Update RedisSentinelManager::Resolve() signature to match Laravel 5.4 update on 17 April #6

Closed jacovdbergh closed 7 years ago

jacovdbergh commented 7 years ago

https://github.com/laravel/framework/commit/d48cab89d5dff44037dac3ed55b9e32a50959cf1

I'm not sure if this will break backwards compatibility for older 5.4 versions?

Thanks.

cyrossignol commented 7 years ago

@jacovdbergh, many thanks for the work. Sorry for the delay...been quite busy. I'll take a look at this tomorrow and try to get a release out. Unfortunately, the changes here do break the package for older 5.4 versions. I have a solution mostly complete that I just haven't found the time to push. Need to write some tests...should be done by the end of the week.

jacovdbergh commented 7 years ago

Thank you for all the work, this is working great in our projects so far. Really appreciate it.