search

monotosh-k / gcp-docs

Download Google Cloud Platform's docs in PDF format
23 stars 15 forks source link

Update for current Google Cloud documentation #9

Open elecnix opened 11 months ago

elecnix commented 11 months ago

Update to parse the current version of Google Cloud documentation.

The code assumed an old version of the documentation, which had different CSS styles. Also, there is no sub-product navigation, so it is removed from the CLI options.

Modernized to an ES6 module instead of CommonJS. Tested on Node v20.10.0.

A very old version of Puppeteer was in use, and needed an update.

Removed cheerio which did not seem necessary, since Puppeteer can pass query selectors to the document.

elecnix commented 11 months ago

@monotosh-k can you please review this PR?

nikitastetskiy commented 9 months ago

Hey, do you got this working ? I am wondering if you could provide a docker or something because there are too many errors to begin with ...

elecnix commented 9 months ago

Hey, do you got this working ? I am wondering if you could provide a docker or something because there are too many errors to begin with ...

Yes, I got it working! Did you try from my elecnix:es6 fork?

nikitastetskiy commented 9 months ago

Yes, it did, thanks! I forgot to switch the branch haha