monovaldes / vscode-linter-codeclimate

VSCode CodeClimate Linter
Do What The F*ck You Want To Public License
4 stars 1 forks source link

Does not work with Remote - Container extension #4

Closed AngellusMortis closed 5 years ago

AngellusMortis commented 5 years ago

So I am using the new Remote Development feature and I cannot get linter-codeclimate to work inside of a Docker container using the Remote - Container extension.

How everything is set up:

I am able to do codeclimate anaylze path/to.py and it works fine from the integrated terminal, but it will not seem to work from the VS Code extension. I am also not able to find any logs for the extension as well, so I cannot figure out what command it is trying to run or even if it has the correct $CODECLIMATE_CODE environment variable.

I have also verified the extension work perfectly outside of Docker.

monovaldes commented 5 years ago

Hi @AngellusMortis , I haven't worked with the new extension yet, probably the exec_path and spawn command are calculated and run locally instead of remotely? referenced lines:

A fix could be:

Feel free to fork the project and propose a solution.

Best regards.

AngellusMortis commented 5 years ago

calculated and run locally instead of remotely?

I do not think it is. The extension actually gets install inside of the Docker container. It should not know anything about the original host (that is why I have to set the $CODECLIMATE_CODE because the Code Climate container actually runs on the original host).

It works great with the Remote - SSH variant, it just has an issue with the Remote - Containers variant of the Remote Development stuff.

Feel free to fork the project and propose a solution.

I would love to, but I am not the best with Javascript and I have never used TypeScript.

AngellusMortis commented 5 years ago

I managed to figure it out. See #5

monovaldes commented 5 years ago

Fix merged and published, thanks!