monovertex / ygorganizer

Source for http://ygorganizer.com
MIT License
8 stars 4 forks source link

Link from card details to card search #28

Open mkaatman opened 9 years ago

mkaatman commented 9 years ago

If I am viewing card details, the name at the top could link to the search for that card.

The use case would be if I was looking at a specific card in my collection, I could click the link and see the search results for that name.

Example: 'Gravity Axe - Grarl' would link to: http://ygorganizer.com/browse/Gravity_Axe_-_Grarl/

Update: I just realized that link only controls the card detail pane. The intention was to update the search results with that card name. Clicking the link would be the equivalent of typing 'Gravity Axe - Grarl' in the browse card mode search input field.

Maybe a link that uses the card number is better.

monovertex commented 9 years ago

Honestly I'm not set on the link controlling only the card viewer. We can change that to reflect the current query / filter options instead.

Then the card viewer does not affect the URL state anymore, and I don't think users will miss that.

Then we can make the titles clickable for searching.

mkaatman commented 9 years ago

I don't know what you're using for routing, but if it looks like it could still be useful, maybe the route could be pushed to /browse/card/{{CardName}}.

monovertex commented 9 years ago

It's Backbone. Really easy to make the change, although I don't really think users would link to our app for a card. They'd rather link the wiki or yugiohprices because an account is needed for ours.

Anyway, I'll keep it, there's very little impact anyway.

mkaatman commented 9 years ago

I don't know! If this interface is superior, I can see people starting to use it in that way. Could card info be displayed without an account?

monovertex commented 9 years ago

We could display the browse page entirely for people without accounts and hide the details that depend on an account, I think.

So no custom columns, no counts and that's about it, I guess. So we could basically keep the links only for the browse page and make a sort of mashup in the links to keep bot the search state and the card viewer state.