This should fix #13 but may have unknown side effects

monperrus / ExpandAnimations

LibreOffice/OpenOffice.org extension to expand animations before exporting to PDF. Looking for maintainers.

https://github.com/monperrus/ExpandAnimations

GNU Lesser General Public License v3.0

232 stars 31 forks source link

This should fix #13 but may have unknown side effects #20

Closed link458 closed 5 years ago

link458 commented 6 years ago

Added some error state handling and catching.

(works for my test case at least)

Ignore white spaces to not be confused - I only changed like 6 lines. I am pretty sure there is a better way to fix it but can't dig deeper into it for now and wanted to provide a solution for the time being.

monperrus commented 6 years ago

Thanks a lot! Could you update the PR to have a clear diff with only the 6 changed lines?

monperrus commented 5 years ago

ping?

rhaschke commented 5 years ago

This seems to be overly complex. For me, it was only necessary to ignore errors in isVisibilityAnimation(). See #27 for an alternative.

monperrus commented 5 years ago

closed per #27