search

monperrus / ExpandAnimations

LibreOffice/OpenOffice.org extension to expand animations before exporting to PDF. Looking for maintainers.
https://github.com/monperrus/ExpandAnimations
GNU Lesser General Public License v3.0
230 stars 30 forks source link

several fixes + improvements #27

Closed rhaschke closed 5 years ago

rhaschke commented 5 years ago

This PR contains several fixes and improvements I made to suit my needs. Please decide on your own whether to consider the individual commits or not.

  1. fix / work-around #13
  2. progress-bar, addresses #19
  3. store expanded .odp in /tmp (only works for Linux) This avoids cluttering my workspace with *-expanded.odp files.
monperrus commented 5 years ago

Thanks a lot for your great contribution, LGTM.

monperrus commented 5 years ago

Thanks a lot!

See packaged file at https://github.com/monperrus/ExpandAnimations/blob/master/dist/ExpandAnimations-0.5.oxt

katz-hm commented 5 years ago

Well, if discontinuing Windows support was intentional, I can live with my local fix, but I wouldn't assume that “only works for Linux“ means “breaks compatibility with Windows“. 0.5 is effectively not working at all under Windows. At least it would make sense (to me) to add a note to the dist folder.