search

monperrus / ExpandAnimations

LibreOffice/OpenOffice.org extension to expand animations before exporting to PDF. Looking for maintainers.
https://github.com/monperrus/ExpandAnimations
GNU Lesser General Public License v3.0
232 stars 31 forks source link

feat: add support for NotebookBar #42

Closed errotu closed 4 years ago

errotu commented 4 years ago

Fixes #41

monperrus commented 4 years ago

LGTM. Does it work as expected?

errotu commented 4 years ago

Works as expected. Just the context value seems to be ignored. The icon is also displayed in Writer or Calc. This seems like a LO bug to me.

Here's a screenshot: grafik

errotu commented 4 years ago

I just checked: The example of the writer2epub-Extension, which is recommended in the wiki, ignores the context value as well. Therefore, it seems like this is an issue on the side of LO, not the extension.

monperrus commented 4 years ago

Thanks for the explanation. So if you undraft the PR, I can merge it.

errotu commented 4 years ago

It's undrafted by now, isn't it?

monperrus commented 4 years ago

Thanks!