monperrus / bibtexbrowser

Beautiful publication lists with bibtex and PHP (standalone or in Wordpress)
http://www.monperrus.net/martin/bibtexbrowser/
84 stars 54 forks source link

Which jquery versions are supported by bibtexbrowser.php ? #126

Closed alf-gerisch-web-de closed 1 year ago

alf-gerisch-web-de commented 1 year ago

Hi, by default bibtexbrowser.php uses the fairly outdated jquery-1.5.1.min.js , see line 79, @define('JQUERY_URI', '//code.jquery.com/jquery-1.5.1.min.js');

This can be updated to a newer version in bibtexbrowser.local.php and I currently use jquery-1.12.4.min.js without trouble: @define('JQUERY_URI', '//code.jquery.com/jquery-1.12.4.min.js'); Even this version is a bit older...

I wonder if there are reasons to stick with the old default 1.5.1 version of jquery or which newer versions can be used without breaking the code.

Hope to get some insight here!

Regards, Alf.

monperrus commented 1 year ago

in theory, it should work even with most recent version of jquery. could you give it a try?

alf-gerisch-web-de commented 1 year ago

I have now set @define('JQUERY_URI', '//code.jquery.com/jquery-3.6.4.min.js'); in bibtexbrowser.local.php and this version is then in fact loading (checked in console of developer tools in firefox and there with: jQuery.fn.jquery ) and it appears to work without problems.

monperrus commented 1 year ago

nice, would you be able to do a pull-request to update the jquery version?

that would be great!