search

monperrus / bibtexbrowser

Beautiful publication lists with bibtex and PHP (standalone or in Wordpress)
http://www.monperrus.net/martin/bibtexbrowser/
84 stars 54 forks source link

Refactor=1 #82

Closed paxperscientiam closed 6 years ago

paxperscientiam commented 6 years ago

A bit of refactoring. The effort here is about separating logic from markup.

monperrus commented 6 years ago

Thanks. Since we don't have a super test suite. I'm hesitant to merge large refactoring, because even a careful code review can miss something. Would you be able to only put in the PR the separation refactoring (and not the other changes such as the introduction of <<<CSS)? Thanks!

paxperscientiam commented 6 years ago

Hello. Maybe I'm misunderstanding. <<<CSS, <<<JS, and <<<HTML are all the same in that they are merely identifiers for the heredocs; they don't affect interpretation by PHP.

I agree with you on the question of testing, which, admittedly, I know little about. Are the tests fed to travis not sufficient?

While we're on testing, I noticed that PHP4 is not included in the travis file. Are you dropping support for PHP4?

monperrus commented 6 years ago

Are the tests fed to travis not sufficient?

no

Are you dropping support for PHP4?

yes

paxperscientiam commented 6 years ago

OK, so made a PR updating the minimum PHP version. As for more comprehensive testing...IDK!