monsieurbiz / SyliusRichEditorPlugin

This plugin add a rich editor on fields to be able to drag and drop elements and edit it.
MIT License
65 stars 37 forks source link

Feat: add enabled attribute for the configuration of UiElements #128

Closed toofff closed 2 years ago

jacquesbh commented 3 years ago

Hey! Thank you for this!

It's a great idea.

I would like to discuss it a bit.

I think disabling a UI Element leads to many points:

In other words, if you disable an element a year later, it could be present in many contents. So we don't want to display it anymore (since it's disabled) but we don't want either to remove it from the old contents since I always say "do not remove data" (as a developer).

So, we need to continue this PR in order to make it work properly I think.

What do you think?

toofff commented 3 years ago

@jacquesbh it was a first draft, but what you propose seems to me very good.

I'm watching this as soon as I can this week.

kevinbalicot commented 3 years ago

Hi @toofff !

Thanks for this PR, it's exactly what I need :D

Possible to check @jacquesbh comments soon ?

toofff commented 3 years ago

@kevinbalicot

I thought I had time but his last days were very complicated. I will see to save myself time next week;)

jacquesbh commented 2 years ago

Hell yeah!

ping @kevinbalicot @toofff <3