search

monsieurbiz / SyliusRichEditorPlugin

This plugin add a rich editor on fields to be able to drag and drop elements and edit it.
MIT License
65 stars 36 forks source link

Error: array to string conversion #152

Closed next-sentence closed 2 years ago

next-sentence commented 2 years ago

this change introduce an exception for all rich editor elements https://github.com/monsieurbiz/SyliusRichEditorPlugin/commit/d1cf85b52f889086e8bb4093800ad77edb4f9aa0#diff-7576ca365f8d9608e42f547cb096b39bcb72c95cbc93756770c78225423e0824R154

sylius 1.10, php 7.4

maximehuran commented 2 years ago

@TonySma do you know why we made this change ?

TonySma commented 2 years ago

Hello,

@next-sentence, sorry for the inconvenience

@maximehuran Yes, we discussed it here: https://github.com/monsieurbiz/SyliusRichEditorPlugin/pull/151/files/d1cf85b52f889086e8bb4093800ad77edb4f9aa0#diff-829b34ef33989639150626c9a37cfd3c0b859aeae1eae5b0db13b89aee31bf8a

I will have a look asap and do more tests

Tony

next-sentence commented 2 years ago

@TonySma, the problem is in FormController:

$formData = $this->processFormData($form, $fileUploader, (string) $request->request->get($form->getName()));

felixgilles commented 2 years ago

Same issue for me after upgrading to Sylius 1.10

maximehuran commented 2 years ago

@felixgilles @next-sentence can you give us the full exception ?

felixgilles commented 2 years ago

Notice: Array to string conversion in vendor/monsieurbiz/sylius-rich-editor-plugin/src/Controller/FormController.php (line 154)

next-sentence commented 2 years ago

153

maximehuran commented 2 years ago

New version released 🚀

felixgilles commented 2 years ago

Many thanks !