Closed gabiudrescu closed 2 years ago
Hey @gabiudrescu !
Of course a PR would be taken into account!
An issue works as well, and we will try to implement it in the next month or two.
@jacquesbh ok, thanks. if we manage to implement it earlier, we'll try to PR here as well.
@jacquesbh there is a PR to address this (curtesy of @next-sentence).
for the time being, we plan on using this from a fork, but we would be grateful if this can be merged and a new version tagged.
the CI seems to fail for a different reason.
Hi @gabiudrescu
I will try to correct the ci in #168 today or tomorrow. Then you will be able to rebase your PR and we will check if tests pass.
@maximehuran 🙏 thank you very much
Released in https://github.com/monsieurbiz/SyliusRichEditorPlugin/releases/tag/v2.0.9 :tada:
thank you very much, @maximehuran 🙏
Sylius allows by default the ability to use Gaufrette as a storage abstraction layer allowing users to host their files in S3 or any other kind of file storage.
It seems this plugin does not allow that, having this class (https://github.com/monsieurbiz/SyliusRichEditorPlugin/blob/master/src/Uploader/FileUploader.php) as a concrete implementation, rather than an interface that can be easily swapped with something else.
Is there any interest in addressing this issue by MonsieurBiz? or would you be willing to accept a PR that addresses this?
either way, a project I am working on plans to implement this, the question is if we can have it in the main repo or if we have to fork it and maintain our own fork.