Add toolbox on top of each richeditor widget

monsieurbiz / SyliusRichEditorPlugin

This plugin add a rich editor on fields to be able to drag and drop elements and edit it.

MIT License

66 stars 38 forks source link

Add toolbox on top of each richeditor widget #212

Closed kgonella closed 4 months ago

kgonella commented 7 months ago

This PR is a proposal to address the issue #93

First commit is only a POC for now to open a discussion on how to implement it.

What is missing :

Verify if all components pasted follow the tags rules (filter out the bad ones)
Alert the user that he will replace the actual content (maybe open a modal with choices : overwrite, add at the end, do nothing)

TODO

[x] Correct issue on delete all
[x] Is it possible to disable the button Paste all if nothing in the clipboard ?

kgonella commented 6 months ago

Hello @maximehuran, thanks for the review.

Can you give me some context, I have tried to do the same test as you and I can't reproduce the bug. I have tried under Firefox / Chrome on Ubuntu.

kgonella commented 6 months ago

Hello @maximehuran, any news ?

maximehuran commented 6 months ago

Hi @kgonella !

I am on Firefox on Mac. I will try again to check if the issue still exist

maximehuran commented 5 months ago

I reproduced the issue on Firefox and Chrome :

https://github.com/monsieurbiz/SyliusRichEditorPlugin/assets/11380627/1a1f93da-4876-4594-a035-8f7c8e87287e

Copy all elements from somewhere
Paste all on an editor which already contains 1 element inside
The pasted element will replace the existing one
Now click on delete all button, you will have the same behaviour as the video.

kgonella commented 5 months ago

Ok I fixedd the issue. As the modal used was the same on multiple calls, the "click' events were stacked and called at the same time. As we can remove event listener easily in javascript, the best way I found was to clone the node and remove the old one.

maximehuran commented 4 months ago

Hi @kgonella 👋

I rebased your PR since the last changes on master. Can you check everything seems ok for you ? Do you think it is possible to disable the button Paste all if nothing in the clipboard ?

Test fails because of two issues with Sylius :

One from Paypal Plugin not corrected yet : https://github.com/Sylius/PayPalPlugin/issues/295
One from Sylius corrected but not released : https://github.com/Sylius/Sylius/issues/16193

maximehuran commented 4 months ago

Thank you @kgonella 🚀