Add a way to prefix index names with var env

monsieurbiz / SyliusSearchPlugin

A search plugin using Elasticsearch for Sylius

MIT License

45 stars 38 forks source link

Add a way to prefix index names with var env #97

Closed Jibbarth closed 2 years ago

Jibbarth commented 3 years ago

Hi !

I wanted to add a prefix because I use the same instance of elasticSearch for multiples projects.

I followed this but I think it should be better to having this directly configurable in the plugin.

With this PR, any user can add MONSIEURBIZ_SEARCHPLUGIN_ES_PREFIX in their .env.local.

WDYT ?

jacquesbh commented 2 years ago

I think that's pretty cool!

jacquesbh commented 2 years ago

Thank you @Jibbarth! A year later 😅. Having this could be great in 2.x (current master branch).

Jibbarth commented 2 years ago

Thanks @jacquesbh. You can probably backport the patch on V2, I don't know if the structure is very different yet. Or let me know, I'll maybe have time to port it in September 😅