monsieurbiz / SyliusSettingsPlugin

Provide some custom settings to your favorite Sylius shop!
MIT License
23 stars 18 forks source link

Default value never fetched in Twig Extension #37

Closed TonySma closed 2 weeks ago

TonySma commented 3 years ago

There is a bug here, if no save action is performed in admin before using this function, then the result will be always null. https://github.com/monsieurbiz/SyliusSettingsPlugin/blob/master/src/Twig/Extension/SettingsExtension.php#L79

The default value in the config file must be used if present.

I will open a PR for this soon.

jacquesbh commented 1 year ago

Hi @TonySma !

Do you still have this issue?

Thanks!