search

monsoonconsulting / magento2-hyva-ajax-add-to-cart

Adds Ajax Add to Cart functionality to Hyva themes
Open Software License 3.0
41 stars 6 forks source link

Register Module for inclusion in hyva-themes.json #18

Closed FinnReinhardtBsc closed 11 months ago

FinnReinhardtBsc commented 11 months ago

In the past, whenever we would run setup:upgrade, this module would be excluded from the hyva-themes.json. This module makes use of Tailwind styles to style the spinner. Thus, in my opinion, it should be included in the tailwind-config.json file.

To achieve this, I followed the instructions provided in the Hyva documentation, to register a module for inclusion:

callanzimmermann commented 11 months ago

Hello @FinnReinhardtBsc, looks great, let me pull this and test it out. I'll let you know.

I'm also looking at dropping support for 7.4 so I'll be updating the PHP files to use some of the PHP8 features. So I might also make some minor amends.

FinnReinhardtBsc commented 11 months ago

Wow, I did not expect such a quick reply from you. Thanks so much for taking your time, @callanzimmermann! I appreciate it!