monstar-lab-oss / ml-frontend

A monorepo created to provide a starter kit for front-end projects at Monstar Lab, Inc.

https://www.npmjs.com/package/start-frontend

Mozilla Public License 2.0

14 stars 1 forks source link

[WIP] Implement plop base #1249

Open ptrkdan opened 6 months ago

ptrkdan commented 6 months ago

[WIP: DO NOT MERGE YET]

Pull Request Checklist

[x] I have checked that this pull request is not a duplicate of a pre-existing pull request
[ ] I have self-reviewed my changes
- [ ] There are no spelling mistakes
- [ ] There are no remaining debug log prints (i.e. console.log())
- [ ] Comments were written for complex code
[ ] I have checked that all tests are passing (for bug fixes and enhancements)
- [ ] CLI Test (npm run test:cli)
- [ ] Unit Test (npm run test:modules)
- [ ] E2E Test (npm run e2e)
[ ] I have added and/or modified relevant tests for my changes (for bug fixes and enhancements)
[ ] I have added and/or modified relevant documentations for my changes (if necessary)

Description

Context

Resolves #(issue)

Before

After

:warning: Breaking changes

Notes

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: ef4f7e0073d9f61b4cc599db70a40c9b0d9c5c86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | start-frontend | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ptrkdan commented 5 months ago

@jinmayamashita @seiya0914 I'm sorry it took long to open up the PR. As I've mentioned in our meeting, I'm planning on using this branch/PR as a base branch for the plop implementation. I will continue to implement the router templates on a child branch, and whoever is available may continue to work on the package.json templates. Once the implementations are done, I will merge it all here, resolve the conflicts and then merge it to main. However, please feel free to add your comments here! 🙏

ptrkdan commented 1 month ago

The CLI test is still failing despite merging the latest update from main. https://github.com/monstar-lab-oss/ml-frontend/actions/runs/10935169811/job/30356449193

It looks like it's failing on the output of tree-cli. Going to investigate it further... (It's passing locally.)