monstar-lab-oss / ml-frontend

A monorepo created to provide a starter kit for front-end projects at Monstar Lab, Inc.
https://www.npmjs.com/package/start-frontend
Mozilla Public License 2.0
14 stars 1 forks source link

Fix CLI test failure by adjusting build process #1292

Closed jinmayamashita closed 2 months ago

jinmayamashita commented 2 months ago

Pull Request Checklist

Description

This pull request fixes the issue with the start frontend CLI test that was failing. The root cause was that the build process was being performed before testing, but the context in which the tests were run was causing the build artifacts to be deleted.

To address this, I modified the CLI test script to build directly before running the tests. This ensures that the necessary build artifacts are present when the tests are executed.

Context

Resolves #1293

Before

The build process was performed before the tests, but the context in which the tests were run was causing the build artifacts to be deleted. This led to the start frontend CLI test failing because the required build files were missing.

After

The CLI test script builds directly before running the tests. This ensures that the build artifacts are present and the start frontend CLI test can run successfully without encountering missing files.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: cfee1a958644cb2e23a96b9f0ecbef99c69cdafa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | start-frontend | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR