search

monstra-cms / monstra

THIS PROJECT IS NOT SUPPORTED ANYMORE! Check FLEXTYPE.ORG
http://flextype.org
MIT License
396 stars 123 forks source link

Monstra 3.0.4 has Stored XSS via Uploading html file that has no extension. #459

Open Hexife opened 5 years ago

Hexife commented 5 years ago

Brief of this vulnerability In uploading process, Monstra file filter allow to upload no-extension file. If html file that has no extension, it can be executed in browser as html, and it causes of Stored XSS.

Test Environment

Affect version <=3.0.4

Payload

  1. move to http://[address]:[port]/[app_path]/admin/index.php?id=filesmanager with admin credential

  2. Save php codes with no extensions. and upload it like below.

    # xss
<html><head><title>Monstra XSS</title></head><body><script>alert('xss');</script></body></html>

  3. Click the uploaded file name or move to http://[address]:[port]/[app_path]/public/uploads/[uploaded file].

  1. Profit!

Reason of This Vulnerability Monstra prevent to upload php-style files using extension filer in uploading process at ./plugins/box/filesmanager/filesmanager.admin.php like below.

#./plugins/box/filesmanager/filesmanager.admin.php
    if ($_FILES['file']) {
        if ( ! in_array(File::ext($_FILES['file']['name']), $forbidden_types)) {
            $filepath = $files_path.Security::safeName(basename($_FILES['file']['name'], File::ext($_FILES['file']['name'])), null, false).'.'.File::ext($_FILES['file']['name']);
            $uploaded = move_uploaded_file($_FILES['file']['tmp_name'], $filepath);
            if ($uploaded !== false && is_file($filepath)) {
                Notification::set('success', __('File was uploaded', 'filesmanager'));
            } else {
                $error = 'File was not uploaded';
            }
        } else {
            $error = 'Forbidden file type';
        }
    } else {
        $error = 'File was not uploaded';
    }

This filtering logic checks that extension of upload file is in their blacklist($forbidden_type variable), but it is not check that extension do not exist in their logic.

Following this logic, No extension file saved with appending '.' at end of filename (e.g. xss -> xss.)

It can be executed in browser(I tested in Chrome ver 68.0.3440.106 (Official Build, 64-bit)) as html and JavaScript.

It can be executed in browser as html, and it causes of Stored XSS.

DanielRuf commented 5 years ago

Ouch. Very unfortunate to see that all these security issues are not resolved and no reaction from the devs.

Hexife commented 5 years ago

I got the CVE for this vulnerability - CVE-2018-18694

DanielRuf commented 5 years ago

I got the CVE for this vulnerability - CVE-2018-18694

Normally it (the vuln) should not be publicly disclosed (at first). But seems the devs do not react which is bad.

Awilum commented 5 years ago

Only Admin can access Admin Panel

DanielRuf commented 5 years ago

Only Admin can access Admin Panel

How can you be sure of that?

A file upload without any checks is dangerous. Anyone who can break into admin can misuse this vuln.

This is an arbitrary file upload vulnerability. See https://www.owasp.org/index.php/Unrestricted_File_Upload

Awilum commented 5 years ago

Okey, I will double check this for New Monstra (Flextype) https://github.com/monstra-cms/monstra/issues/460 Thanks for your contribution!

Hexife commented 5 years ago

@DanielRuf Thank you for answer instead of me.

In my opinion, File upload feature MUST have the file filtering logic.

There are many possibilities for stealing admin authority. Anyone can't convince that admin panel is only able to access with admin authority. So, I appreciate @Awilum for understanding value of my report and applying it to your new project.

Thank you guys!

Hexife commented 4 years ago

Also, XHTML(https://www.w3schools.com/html/html_xhtml.asp, MIME : application/xhtml+xml) file could trigger the JavaScripts.

Please consider xhtml in your next project - flextype.

Thank you.