monsur / enable-cors.org

Advocacy for CORS
http://enable-cors.org/
208 stars 98 forks source link

Should flowchart say "Continue processing request" where is says "Not a valid CORS request"? #158

Open nickform-ost opened 3 years ago

nickform-ost commented 3 years ago

First of all, thanks for this very useful resource.

This is really just a question. Since the flowchart is described as a "flowchart for implementing CORS support" I think it would be useful if all terminals contained actions rather than conclusions. When a request is not a CORS request, the server should just process it without adding any of the CORS headers. Thus, wouldn't it make sense if the "No" branch of the first decision connected to "Continue processing the response"?

As for the other red terminal "Not a valid preflight request", perhaps it would be more helpful to say "return 400 with a body describing the problem"?