search

monsur / enable-cors.org

Advocacy for CORS
http://enable-cors.org/
208 stars 98 forks source link

Remove reference to Caddy as instructions are incorrect. #167

Closed rozza-m closed 7 months ago

rozza-m commented 7 months ago

Caddy 2 (branded as just "Caddy") has replaced Caddy 1 as of May 2020.

enable-cors.org instructions for Caddy don't work on Caddy 2 and Caddy will not load with the directives in place as specified (i.e. it breaks the server).

To avoid causing harm by breaking people's Caddy configs, this pull removes all reference to Caddy completely. Ref #153

joshbmarshall commented 7 months ago

Why remove it when I've given the config that works perfectly with Caddy 2? https://github.com/monsur/enable-cors.org/issues/153#issuecomment-1152936304

Would make more sense to update the information instead.

joshbmarshall commented 7 months ago

Instructions do work with Caddy version 1. It might be that nobody is running it any more but what if someone is and needs to enable cors? Pull request #168 changes the terminology to make it specific it's for version 1.

rozza-m commented 7 months ago

Why remove it when I've given the config that works perfectly with Caddy 2? #153 (comment)

Would make more sense to update the information instead.

100% agree :) At the point I submitted the MR there was no "correct" information for caddy 2 on enable-cors.org (and supplying caddy 1 info on the website as just "caddy" and expecting that people would find their way to your github comment is of course not sufficient). But now that the correct info is available that's a way better solution than simply removing the Caddy 1 info.