search

monsur / enable-cors.org

Advocacy for CORS
http://enable-cors.org/
208 stars 98 forks source link

Fix ExpressJS for recent versions of chrome #79

Closed alexanderGugel closed 9 years ago

alexanderGugel commented 10 years ago

See http://stackoverflow.com/a/8658281/3773544 for further reference

alexanderGugel commented 9 years ago

Thanks, you're right. Has been removed now.

monsur commented 9 years ago

I accepted your patch, but now I'm curious to get to the bottom of this issue. What browser and version are you using? Maybe certain browsers expect the Origin header?

alexanderGugel commented 9 years ago

I believe only the most recent versions of chrome. I just tested it with Chrome 37.0.2062.124 and it only works with my commit. Firefox 31 works without.

Testing it on Sauce Labs would be a good idea, probably going to spend some time on the weekend figuring out which browsers are affected.