search

montagejs / collections

This package contains JavaScript implementations of common data structures with idiomatic interfaces.
http://www.collectionsjs.com
Other
2.09k stars 185 forks source link

Fix for a regression in Montage’s repetition where objects inside the re... #102

Closed marchant closed 9 years ago

marchant commented 9 years ago

...petition were not being notified of changes anymore. This worked as expected in collections version 1.1.0 but has been broken since. A test has been added to montage specs to catch future regressions

kriskowal commented 9 years ago

Looks good to me.

kriskowal commented 9 years ago

This would preferably include a test here, in addition to the test in Montage, so that unit tests reveal the problem before integration tests would.

marchant commented 9 years ago

Agreed, but I couldn't figure out in a timely manner a collection level only simple test that would cover it!

On Dec 1, 2014, at 16:54, Kris Kowal notifications@github.com wrote:

This would preferably include a test here, in addition to the test in Montage, so that unit tests reveal the problem before integration tests would.

— Reply to this email directly or view it on GitHub.