montagejs / collections

This package contains JavaScript implementations of common data structures with idiomatic interfaces.
http://www.collectionsjs.com
Other
2.09k stars 185 forks source link

Fix dispatch and length issues in SortedArray.swap #106

Closed fredkilbourn closed 9 years ago

fredkilbourn commented 9 years ago

Dispatch issues are detailed in #104.

Length issue is newly discovered.

fredkilbourn commented 9 years ago

I just committed another bugfix to my fork and it showed up here, I don't know if it is now part of this pull request or not? https://github.com/fredkilbourn/collections/commit/1cf2a488e6ae2ecbd7984d886af4d505e10f4852

kriskowal commented 9 years ago

These look good to me. I’m making a note to cherry pick them into v2 as well.