montagejs / collections

This package contains JavaScript implementations of common data structures with idiomatic interfaces.

http://www.collectionsjs.com

Other

2.09k stars 185 forks source link

Array.find seems to be broken again #185

Closed yang closed 6 years ago

yang commented 6 years ago

Tested 5.0.7.

hthetiot commented 6 years ago

Looking into it.

hthetiot commented 6 years ago

@yang Can you try npm install collections@2.0.3 that should fix your issue

I'm going to merge the overdue v2 branch in master and release v6 soon. In the mean time I'm going to attempt to provide a fix to the recurring Array.prototype.find issue.

hthetiot commented 6 years ago

PR fix https://github.com/montagejs/collections/pull/188

hthetiot commented 6 years ago

@yang

Fixed in collections 5.1.0

For legacy issue notification of release: cc @Jorenm @codebling @kylehg @xjamundx @kylehg

codebling commented 6 years ago

Will check that out, thanks for the cc!

codebling commented 6 years ago

162 is still broken

erothmayer commented 5 years ago

This appears to still be a problem (or another breaking change to the base language collections is similarly broken). In 5.1.8 3rd party libraries still have unexpected failures, while going back to 2.0.3 fixes them.

codebling commented 5 years ago

See also issues #36 #70 #94 #95 #116 #139 #145 #162 #165 #169 #178 #182 #185 #197 #215 #220 and PRs #94 #95 #116 #173 #189 #212. As mentioned, branch v2 fixes these issues by avoiding global object modification.