Extension of native constructors with utility functions

montagejs / collections

This package contains JavaScript implementations of common data structures with idiomatic interfaces.

http://www.collectionsjs.com

Other

2.09k stars 185 forks source link

Extension of native constructors with utility functions #197

Open ioncreature opened 6 years ago

ioncreature commented 6 years ago

Hello!

I like the library. But.

But I do not want this library to add anything to Object, Function or any other native entity.

This approach could conflict with developer if developer wants to extend base entities in own project It could conflict with other libraries like SugarJS It could conflict with future versions of JS

Please, use your utility functions locally(and import it when it needed) and do not make it global

hthetiot commented 6 years ago

@ioncreature Check v2 branch.

https://github.com/montagejs/collections/tree/v2

We are aware of the issue with current version. We don't have the bandwidth to fix v1 for now, any PR welcome.

codebling commented 5 years ago

See also issues #36 #70 #94 #95 #116 #139 #145 #162 #165 #169 #178 #182 #185 #197 #215 #220 and PRs #94 #95 #116 #173 #189 #212. As mentioned, branch v2 fixes these issues by avoiding global object modification.