search

montagejs / collections

This package contains JavaScript implementations of common data structures with idiomatic interfaces.
http://www.collectionsjs.com
Other
2.09k stars 185 forks source link

fix Sorted-Set.reduceRight #206

Closed AIRTucha closed 6 years ago

AIRTucha commented 6 years ago

Sorted-Set.reduceRight had incorrect reduction order for refuceRight. It was caused by an incorrect recursive call.

hthetiot commented 6 years ago

LGTM

hthetiot commented 6 years ago

would be nice to have a test on your original issue @AIRTucha

AIRTucha commented 6 years ago

oh, I tried, but I had some issues with running tests on Win 10.

Actually, I run the fix in production since April and it seems to work well.

Soon,I might have time to make the test from home(mac os, linux), but I can't promise.