search

montagejs / collections

This package contains JavaScript implementations of common data structures with idiomatic interfaces.
http://www.collectionsjs.com
Other
2.09k stars 183 forks source link

Set.reduceRight seems to be incorrect. #210

Closed Nikolsi closed 5 years ago

Nikolsi commented 6 years ago

Set.reduceRight did not callback at all. It was caused by not using the reverseOrder array and incorrect index counting.

I have created a pull request #209 with fix for it

Nikolsi commented 5 years ago

Does anybody here? :D

marchant commented 5 years ago

Thanks @Nikolsi for the nudge and providing the patch, just merged, sorry for the delay!

Nikolsi commented 5 years ago

@marchant Thank you for accepting the merge request 👍