Property change listener efficiency changes

montagejs / collections

This package contains JavaScript implementations of common data structures with idiomatic interfaces.

http://www.collectionsjs.com

Other

2.1k stars 183 forks source link

Property change listener efficiency changes #86

Closed kriskowal closed 10 years ago

kriskowal commented 10 years ago

Using direct non-enumerable __ prefixed properties instead of weak maps for fast access to change listener records and overridden property descriptors.
Method names and reusable active dispatch array now kept in book keeping to avoid recomputation.
Presumed hot dispatch loop factored into separate method to isolate from try/catch deoptimization.
Removed support for uninstalling property change listeners.

Stuk commented 10 years ago

Do you have any data on if this is faster/uses less memory?

kriskowal commented 10 years ago

We do not have a meaningful benchmark, micro nor macro. However, I ran the FRB test suite against the before and after branches. The data do not indicate a meaningful change.

master
1.065
1.157
1.059
1.092
1.059
1.057
1.064
1.046
1.032
1.043
1.049
1.080
1.096
1.124
1.114
1.059
1.059
1.171
count 18
sum 19.426
average 1.07922222222
stdev 0.29576014298

need for speed
1.111
1.102
1.040
1.029
1.121
1.053
1.161
1.067
1.078
1.219
1.059
1.052
1.041
1.116
1.087
1.070
1.051
count 17
sum 18.457
average 1.08570588235
stdev 0.280119188979

kriskowal commented 10 years ago

Unrolled the swap.


master
1.198
1.050
1.048
1.052
1.059
1.053
1.034
1.046
1.027
1.048
1.139
1.053
1.048
1.175
1.039
1.078
1.108
1.220
1.091
1.071
1.110
1.060
1.112
1.316
1.077
1.087
1.137
1.165
1.250
1.121
1.066
1.079
count 32
sum 35.217
average 1.10053125
stdev 0.204254782774

ndeed for speed
1.142
1.174
1.033
1.034
1.045
1.109
1.176
1.052
1.030
1.119
1.082
1.030
1.148
1.065
1.033
1.125
1.144
1.157
1.234
1.042
1.081
1.034
1.088
1.045
1.098
1.071
1.081
1.030
1.043
1.090
1.111
count 31
sum 33.746
average 1.08858064516
stdev 0.213104194629

marchant commented 10 years ago

Slightly better but a win if less objects created, did you compare that besides the temp array gone?

On Jul 1, 2014, at 14:53, Kris Kowal notifications@github.com wrote:

Unrolled the swap.

master 1.198 1.050 1.048 1.052 1.059 1.053 1.034 1.046 1.027 1.048 1.139 1.053 1.048 1.175 1.039 1.078 1.108 1.220 1.091 1.071 1.110 1.060 1.112 1.316 1.077 1.087 1.137 1.165 1.250 1.121 1.066 1.079 count 32 sum 35.217 average 1.10053125 stdev 0.204254782774

ndeed for speed 1.142 1.174 1.033 1.034 1.045 1.109 1.176 1.052 1.030 1.119 1.082 1.030 1.148 1.065 1.033 1.125 1.144 1.157 1.234 1.042 1.081 1.034 1.088 1.045 1.098 1.071 1.081 1.030 1.043 1.090 1.111 count 31 sum 33.746 average 1.08858064516 stdev 0.213104194629 — Reply to this email directly or view it on GitHub.