montagejs / minit

Tool: Helps you build Montage applications by generating template applications and components for you.
Other
8 stars 22 forks source link

Simplify sample template #96

Open cdebost opened 3 years ago

cdebost commented 3 years ago

The straightforward bit:

For review:

tejaede commented 3 years ago

Removes the assets/style/style.css from samples in favor of using the main app's stylesheet. I think it's much better to ensure some consistency in the global style rules and avoid surprises when moving from the sample to the actual app.

I agree that it's best to match the app's global style in the sample, but UI Kits don't have or need a global stylesheet so this results in a 404 and no global styles are applied. Maybe we can check for the existence of the main app stylesheet and only point to it if it exists? If not, I think it's better to leave it generic and make it the responsibility of the developer to match the sample styles to the app styles.