search

montagejs / mop

Montage Optimizer (mop): Minifies (to reduce file size) and creates bundles (to reduce the number of requests) of Montage applications.
Other
31 stars 15 forks source link

Support Windows #50

Closed Stuk closed 10 years ago

kriskowal commented 10 years ago

I would love feedback on whether these changes are effective from someone who uses Windows as their primary. Perhaps word from @onezeroonezero.

Stuk commented 10 years ago

All comments addressed.

Stuk commented 10 years ago

This PR seems to break mopping some apps that previously mopped fine on OSX. Investigating.

Stuk commented 10 years ago

Problem fixed. I was using .innerHTML instead of .textContent in transform/html getText.

Stuk commented 10 years ago

Rebased on top of master

onezeroonezero commented 10 years ago

Turns out problem I was experiencing was due to space character in directory absolute path name - Program Files - mop works just fine when run from a directory with no space in its path name Thanks for the effort guys. Great work!

Stuk commented 10 years ago

@kriskowal want to merge this? I've heard of a couple of successes.