search

montagejs / mop

Montage Optimizer (mop): Minifies (to reduce file size) and creates bundles (to reduce the number of requests) of Montage applications.
Other
31 stars 16 forks source link

Attempted fix of mop #62

Closed rayshan closed 8 years ago

rayshan commented 8 years ago

Hi @marchant, can you try this branch? It doesn't seem to exit randomly for me on mac or linux now. The resulting build works on mac, but on linux it gives below errors:

GET http://192.168.99.100:4000/packages/montage@6527381/node_modules/bluebird/js/browser/bluebird.min.js 
browser.load @ montage.js:586
browser.bootstrap @ montage.js:699
exports.initMontage @ montage.js:54
(anonymous function) @ montage.js:891
(anonymous function) @ montage.js:39
(anonymous function) @ montage.js:41

And 2 similar errors, one for http://192.168.99.100:4000/packages/montage@6527381/node_modules/mr/require.js, another for http://192.168.99.100:4000/packages/montage@6527381/node_modules/mr/browser.js. Looks like rewriting of paths didn't work somewhere. I'll keep looking tomorrow.

rayshan commented 8 years ago

PR is updated with working mop, tested on mac and linux. Note the tests are failing due to tests using q-io/mockFs, but things actually do work. We need to reduce test dependencies on q-io as well.

marchant commented 8 years ago

Tested, merging in, couple of test issues to resolve