search

montagejs / mop

Montage Optimizer (mop): Minifies (to reduce file size) and creates bundles (to reduce the number of requests) of Montage applications.
Other
31 stars 15 forks source link

Improve flexibility with github dependencies #83

Closed cdebost closed 6 years ago

cdebost commented 6 years ago

Currently mop only handles version checking if the dependency predicate starts with github.com:, but there are plenty of other valid github URL formats, this PR adds them all.

Also currently mop is inconvenient when working with a manually cloned copy of mr and/or montage. You have to manually add a _from attribute in the dependency's package.json in order to make mop happy. This PR changes mop to just output a warning if it sees a dependency that is supposed to be installed through npm+github but doesn't have a _from attribute.

hthetiot commented 6 years ago

lgtm

try to test via travis if possible otherwise merge

cdebost commented 6 years ago

Merged via #82.