search

montagejs / screening

50 stars 16 forks source link

Updating to Master Montage #250

Closed zacharyc closed 12 years ago

zacharyc commented 12 years ago

There was a big change here, hence the pull request. Montage removed support for id="" tags and now requires data-montage-id. I've updated the html files to reflect this

irinamok commented 12 years ago

Do we still want to keep ids? No harm in having both id and data-montage-id?

eliseosoto commented 12 years ago

Apparently there's no harm in keeping the id, but from what I see in the Montage examples they basically did a find-and-replace from id to data-montage-id.

I think you'd only want to keep the id if you want your elements to be easily selectable, which is the case for many of our applications under test.