search

montagejs / screening

50 stars 16 forks source link

We should disable "Download All" button if there are no scripts #278

Closed irinamok closed 12 years ago

irinamok commented 12 years ago

Remove all scripts. Click Download All - {"error":"Error creating ZIP file, zip command exited with code: 12","stack":"Error: Error creating ZIP file, zip command exited with code: 12\n at ChildProcess. (/Users/ntvd76/workspace/screening/server/rest-api/scripts.js:146:33)\n at ChildProcess.emit (events.js:70:17)\n at maybeExit (child_process.js:360:16)\n at Socket. (child_process.js:465:7)\n at Socket.emit (events.js:67:17)\n at Array.1 (net.js:335:10)\n at EventEmitter._tickCallback (node.js:192:40)"}

zacharyc commented 12 years ago

I don't think the button should be disabled, necessarily, but the action should be more response to the user, something like "there are no scripts to download."

irinamok commented 12 years ago

Either way is fine as long as we do not display a long ugly message in the browser.