montblu / terraform-octopusdeploy-bootstrap

Simple Terraform module used to manage a Octopus instance
https://registry.terraform.io/modules/montblu/bootstrap/octopusdeploy/latest
GNU General Public License v3.0
0 stars 0 forks source link

Moving registry information inside var.deployment_projects #33

Closed jdaMachado closed 3 days ago

jdaMachado commented 1 week ago

We will start using separate ECR per environment for client deployments. This requires a change in how the ecr image url is set for the octopusdeploy_deployment_process steps. Since only one environment is supposed to create these resources, we should setup each ecr information inside the deployment_projects map we feed the module.

Example: { "analyze" = { "ecr" = "" }, }

so we can then reference in the step as: bash -c "kubectl set image deployment/${each.key} ${each.key}=${each.value.ecr}${each.key}:$(get_octopusvariable "Octopus.Release.Number") && kubectl rollout status deployment ${each.key}"

jdaMachado commented 4 days ago

A better solution is to just use octopus variables for the ecr url values and set them per environment. This requires the module to run in every environment. Singleton resources will need a flag to control creation.

MiguelNdeCarvalho commented 3 days ago

Fixed in #36