montera34 / pageonex

PageOneX. Analyzing front pages
http://pageonex.com
GNU Affero General Public License v3.0
54 stars 13 forks source link

Areas show overlapped, though in the coding view they are not #153

Closed numeroteca closed 11 years ago

numeroteca commented 11 years ago

Example:

Other layers with wrong overlapping areas:

I am not able to find a pattern.

rahulbot commented 11 years ago

I believe this is a data error, for instance, for the image at /numeroteca/arab-spring-in-spanish-newspapers/coding/?i=elpais-2011-02-15 I see the following area:

[[#<Area id: 1483, x1: 321, y1: 247, x2: 749, y2: 1502, highlighted_area_id: 1237, created_at: "2013-05-27 05:04:05", updated_at: "2013-05-27 05:04:05", width: 428, height: 589>]]

Notice that the while the height says 589, y2 - y1 = 1245! That's a data problem. We must be using width everywhere else to show things. My image-creation code is using y1 and y2. When I change it to use y1+height, it works fine. I similarly change it to use x1+width.

One could make a strong argument that we don't need x2,y2 AND width,height... so perhaps we should remove x2,y2 to resolve the underlying bug?