search

montera34 / pageonex

PageOneX. Analyzing front pages
http://pageonex.com
GNU Affero General Public License v3.0
54 stars 13 forks source link

Wrong alignment of images and bar chart for long threads #155

Closed numeroteca closed 10 years ago

numeroteca commented 11 years ago

The wrong alignment of images and bar chart for long threads like http://pageonex.com/numeroteca/corrupcion-spain-enero-2013/

Chart bars and numbers are shorter than the images.

130606_wrong-alignment-barchart-images

It might be caused by the (conditional) padding for the images? https://github.com/numeroteca/pageonex/blob/master/app/models/threadx.rb#L141

numeroteca commented 11 years ago

The alignment looks great now, thanks.

  1. This feature added an extra gap at the left, which makes newspapers names at the left be displayed too far. Would it be possible to make the images start at the beginning of x axis.
  2. Would it be possible to remove the ticks (small black lines, that go with each date) in x axis.

Besides, days ago I added an extra black line at the bottom so we would have the base line on top of the bars, but it looks too big. Is it possible to make it be just 1px width stroke? I could not manage to do it.

numeroteca commented 11 years ago

Wrong alignment chart-images for short threads (7 days): pageonex_wrong_alignment

Thinking on how to solve the visualization for short threads, they are usually to long in the vertical size.