search

montera34 / pageonex

PageOneX. Analyzing front pages
http://pageonex.com
GNU Affero General Public License v3.0
54 stars 13 forks source link

Position of newspaper names in display should take in account the relative padding added to the images #161

Closed numeroteca closed 11 years ago

numeroteca commented 11 years ago

In threads with more than 2 newspapers the name of the paper is not aligned is not aligned with the row.

Ex: http://pageonex.com/numeroteca/geziparki/

numeroteca commented 11 years ago

Fixed in part e519fa4f, but it is not conditional.

numeroteca commented 11 years ago

I'll better explain the problem with an image: alignment-newspaper-labels

The newspapers names in the left column, beside the array of images, are not properly align with the images in the graphic. That's why I added the manual padding of 8px in e519fa4, though it should be a conditional padding to match the padding indicated in threadx.rb: padding = self.duration > 10 ? 3 : 8 # default padding logic

numeroteca commented 11 years ago

Ups, sorry, I get it! It's working now, I just had to update the threads.

I hadn't notice that we were taking the height from the img_map. Great!