montera34 / pageonex

PageOneX. Analyzing front pages
http://pageonex.com
GNU Affero General Public License v3.0
53 stars 13 forks source link

Update footer supported by section #242

Open numeroteca opened 2 years ago

numeroteca commented 2 years ago

The footer is defined in the application.html.erb file. It is a .erb file that controls the basiclayout of all the pages in the app (except the embedded ones).

We need to change the "Supported by Center for Civic Media" to "Supported by Montera34".

numeroteca commented 2 years ago

In order to see the results of your changes you can not use the docker compose and the existing generated docker images, because you will see the pre-existing docker image, that won't be affected by your edits. To make some development you have to use docker-compose and build locally the docker modified image. Follow the installation manual and see that you are able to install it using this mode.

numeroteca commented 1 year ago

I made the changes to the file 920b547e37.

numeroteca commented 1 year ago

Following this manual, I've been ale to rebuild the image container. with sudo docker-compose -f docker-compose-build.yml up -d --build

Successfully tagged pageonex_app_build:latest
pageonex_mysql_build_1 is up-to-date
Recreating pageonex_app_build_1 ... done

Now, @rporres, what have I got to do to create and upload the new image to the Docker Hub (https://hub.docker.com/r/pageonex/ruby-base/tags/)?

When I do make docker-build I get:

VERSION variable cannot be empty.
make: *** [Makefile:22: docker-build] Error 1

How to include the version? Is the related to the creation of a tag?

rporres commented 1 year ago

this should work

make docker-build VERSION=0.2.0

Another thing you can try is to create a 0.2.0 tag in the repository. That should trigger a docker build/push job to DockerHub.

numeroteca commented 1 year ago

The first throws this error:

/pageonex$ make docker-build VERSION=0.2.0
error checking context: no permission to read from '/home/numeroteca/sites/pageonex/app/assets/images/threads/1/1/970/results.zip'
make: *** [Makefile:22: docker-build] Error 1

The second, after creating the 0.0.2 tag and make docker-build:

/pageonex$ make docker-build
VERSION variable cannot be empty.
make: *** [Makefile:22: docker-build] Error 1

I don't know it the new tag has triggered ¿travis? make this new version.

rporres commented 1 year ago

I will change VERSION as I see that v0.0.2 is an existing tag.

The examples will clone a clean pageonex repo from the main repo, not from your fork. This is important for tag creation and for container creation.

git clone https://github.com/montera34/pageonex
cd pageonex
export VERSION=v0.3.0
git tag $VERSION
git push origin $VERSION

Then wait a few minutes and check tags in https://hub.docker.com/r/pageonex/pageonex/tags

It this doesn't work, then you can try with:

git clone https://github.com/montera34/pageonex
cd pageonex
export VERSION=v0.3.0 
make docker-build 
export DOCKER_USERNAME=pageonexrobot
export DOCKER_PASSWORD=<REDACTED> # you should have this, ping me if you don't
make docker-push