monterail / ghcr

[Project discontinued] GitHub Code Review Extension
https://github.com/monterail/ghcr
27 stars 1 forks source link

Firefox version doesn't work #39

Closed jandudulski closed 10 years ago

jandudulski commented 10 years ago

Just nothing happens :(

chytreg commented 10 years ago

To "just" napraw to!

chytreg commented 10 years ago

`error: ghcr: An exception occurred. Error: Module: ghcr/main has no authority to load: sdk/request ghcr/main 107 Traceback (most recent call last): File "resource://gre/modules/NetUtil.jsm", line 140, in aCallback(pipe.inputStream, aStatusCode, aRequest); File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/net/url.js", line 49, in resolve(data); File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve while (pending.length) result.then.apply(result, pending.shift()) File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then return { then: function then(resolve) { resolve(value) } } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved function resolved(value) { deferred.resolve(resolve(value)) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve while (pending.length) result.then.apply(result, pending.shift()) File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then return { then: function then(resolve) { resolve(value) } } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved function resolved(value) { deferred.resolve(resolve(value)) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve while (pending.length) result.then.apply(result, pending.shift()) File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then return { then: function then(resolve) { resolve(value) } } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved function resolved(value) { deferred.resolve(resolve(value)) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve while (pending.length) result.then.apply(result, pending.shift()) File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then return { then: function then(resolve) { resolve(value) } } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved function resolved(value) { deferred.resolve(resolve(value)) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve while (pending.length) result.then.apply(result, pending.shift()) File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then return { then: function then(resolve) { resolve(value) } } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved function resolved(value) { deferred.resolve(resolve(value)) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve while (pending.length) result.then.apply(result, pending.shift()) File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 123, in then else result.then(resolved, rejected) File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then return { then: function then(resolve) { resolve(value) } } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved function resolved(value) { deferred.resolve(resolve(value)) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 55, in effort try { return f(options) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved function resolved(value) { deferred.resolve(resolve(value)) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve while (pending.length) result.then.apply(result, pending.shift()) File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then return { then: function then(resolve) { resolve(value) } } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved function resolved(value) { deferred.resolve(resolve(value)) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 55, in effort try { return f(options) } File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/addon/runner.js", line 90, in onLocalizationReady run(options); File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/addon/runner.js", line 122, in run let program = main(options.loader, options.main); File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/ghcr/lib/main.js", line 1, in var PageMod,Request,self,ss;PageMod=require("sdk/page-mod").PageMod,Request=require("sdk/request").Request,self=require("sdk/self"),ss=require("sdk/simple-storage"),exports.main=function(){return new PageMod({include:"https://github.com/*",contentScriptFile:[self.data.url("ghcr.js")],contentStyleFile:[self.data.url("ghcr.css")],onAttach:function(a){var b;return b=function(b,c,d,e){return Request({url:b,content:c,headers:{"X-Requested-With":"XMLHttpRequest"},onComplete:function(b){var c;return c=b.status<400?d:e,a.port.emit(c,b.json||{})}})},a.port.on("request:get",function(a,c,d,e){return b(a,c,d,e).get()}),a.port.on("request:post",function(a,c,d,e){return b(a,c,d,e).post()}),a.port.on("request:put",function(a,c,d,e){return b(a,c,d,e).put()}),a.port.on("storage:get",function(b,c){return a.port.emit(c,ss.storage[b])}),a.port.on("storage:set",function(b,c,d){return ss.storage[b]=c,a.port.emit(d)})}})}; File "resource://jid0-xljaelmykqiekaiyiba8v9sbl4o-at-jetpack/addon-sdk/lib/sdk/loader/cuddlefish.js", line 107, in resolve

@Ostrzy @jandudulski any idea what is going on? When I run FF in dev mode I get this error and extension is working, in normal mode just doesn't work

Ostrzy commented 10 years ago

After some searching I have no idea what's going on with that. Maybe addon-sdk has changed and we should use newer one? But request is from addon-kit, so I have no idea what can ba about this. Firefox, Y U so bad to us...

chytreg commented 10 years ago

We do not support firefox anymore.