Describe what you're going to do in issue before doing anything

[sheerun]

As proposed by @Ostrzy. That way no one will be surprised by big pull-request, as everyone will be at least notified you're going to change something.

This is connected to my refactor in ghcr, but I see other people doing that as well, for example @teamon in rails-assets, which is indeed annoying.

This guideline is mainly for open source and internal projects.

Such issue can be easily converted to pull-request later on.

[Ostrzy]

:+1:

[sheerun]

@chytreg @jandudulski @teamon @tallica @porada @jcieslar @venticco

[bartoszrega]

:+1:

[szajbus]

meh :+1:

[teamon]

This is not as simple as it looks like, but :+1:

[Ostrzy]

@teamon Probably not, but better try something simple and adjust, than just being constantly pissed off ;)

[porada]

YOU GUYS OBVIOUSLY DON’T AIM FOR THE WOW EFFECT

[porada]

:+1:

[jandudulski]

This issue is going to achieve a gold medal in "Best issue of the year" category.

Obvious :+1:

[sheerun]

@teamon Please merge

[teamon]

Are you sure about the placement of this line in top-level README? This only applies to projects with issues on github.

[sheerun]

@teamon Where to put it?

[porada]

touch Internal.md

[sheerun]

I'd vote git.md, updated.

[teamon]

How is that a git guideline? oO

"Internal" or "GitHub" seems fine. (GitHub even more, all of guidelines are kind of internal)

[sheerun]

How it is not

[porada]

[teamon]

This is not general git rule for all projects, it is valid only for small part of them. I'd even go further and propose OpenSource.md.

[sheerun]

Maybe rename git to opensource...

[teamon]

Git.md applies to all projects. This guideline does not.

[jandudulski]

Git is git. Opensource is opensource.

If I would be looking for the preferred settings for git I will be looking for a git.md. If I would be looking for the preferred way to contribute - opensource.md will be my first hit.

[sheerun]

Whatever, here you have your open source md

[teamon]

Thank you :)