Use #noreview for commits not needing review

[Ostrzy]

Examples of such commits:

• precompiling assets
• pulling translations from localeapp
• debug logging
• automatically generated

[sheerun]

[noreview] in commit description is probably more canonical

[teamon]

More canonical with what?

[szajbus]

@sheerun are there any conventions regarding commit messages? I mean, not our guidelines, but git world in general.

[bartoszrega]

[sheerun]

http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html + Travis CI and other tools use [flags] in square brackets in commit description, to not pollute git history.

[porada]

Travis checks for [ci skip] or [skip ci], so I propose [review skip] or something similar. #noreview sucks balls, because you have to find a workaround in order to put it as the first in a new line (such flags should never appear in the first line of commit message—neither should fixes #1 etc.)

[sheerun]

[skip review], [ci skip] is backwards https://github.com/travis-ci/travis-ci/issues/911

[teamon]

/\[(skip.*review)|(review.*skip)\]/

[Ostrzy]

This one we are using now. Not catching only backward one. /#?(no|skip)\s?(code\s?)?review/

[teamon]

I think "#" or "[ ]" should be mandatory to prevent false positives.

[porada]

Agreed with @teamon.

[Ostrzy]

@teamon argument is fine with me. So I guess decision is to use "[]"?

[teamon]

/\[\s*(no|skip)\s+(code\s*)?review\s*\]/ + reverse

[jandudulski]

:+1:

[Ostrzy]

@teamon Reverse You say? [review code no]?

[teamon]

[(no|skip) (code) review] or [review (no|skip)]

[sheerun]

who the hell is going to write [skip code review] instead of [skip review]

[Ostrzy]

@teamon The first one is quite natural, but when I read the second one, I feel like I should have lightsabre. I'm opting for no reverse. @sheerun I have no idea :grinning:

[teamon]

The reverse started with [ci skip] but I'm fine with "just" [(no|skip) review] and nothing more.

[Ostrzy]

:+1: for [(no|skip) review]

[teamon]

@Ostrzy PR plz

[teamon]

@Ostrzy

[teamon]

@Ostrzy !