monterail / guidelines

[DEPRECATED] We are Ruby on Rails experts from Poland. Think hussars. Solid & winged. These are our guidelines.
71 stars 17 forks source link

Add short note when using gem version from repository #189

Closed szajbus closed 10 years ago

szajbus commented 10 years ago

Add a short note to Gemfile when using a custom version of a gem. Example:

# We need these commits: 81891ca, 361abca, abc1823 from master branch. 
gem 'activeadmin', github: 'gregbell/active_admin'

The idea is to know when the declaration can be switched back to using officially released version of the gem.

@jandudulski, @sheerun, @chytreg, @teamon, @Ostrzy, @jcieslar, @tallica, @porada, @venticco, @Ostrzy, @michlask

teamon commented 10 years ago

SO MUCH YES YES YES YES YES YES YES YES YES YES YES YES YES YES YES

bestguidelineever

jandudulski commented 10 years ago

:+1:

venticco commented 10 years ago

yes

sheerun commented 10 years ago

It's not necessary. You just issue:

git log ..original/v2.0.5

From gem directory to check if all commits from revision defined in Gemfile.lock are present in newest release.

Also it's not always clear what commits are necessary. You sometimes include master because it's working, and you don't really need to do research which commits were necessary.

teamon commented 10 years ago

There should always be a comment why we use this specific fork/commit. Like # We need feature X that is available only in this branch

sheerun commented 10 years ago

And that makes sense

sheerun commented 10 years ago

@szajbus Please PR

teamon commented 10 years ago

@szajbus PRRRRRR!

teamon commented 10 years ago

@szajbus

szajbus commented 10 years ago

better late than never ;)